Add quotes according to the stylelint rule #27771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But it seems we got no failures. Just FYI I remember this quotes issue in the past and IIRC the spec does allow a whitespace without quotes. That being said I'm all for it for consistency, I'd just feel safer if Stylelint (SCSS) complained. |
|
It never fails. If a font family is defined as an SCSS variable, lint does not work (regardless of whether correct or not). In other words, it is ignored. The following CSS gets linted: a { font-family: Noto Sans; }But the following SCSS doesn't get linted. $font: Noto Sans;
a { font-family: $font; } |
XhmikosR
approved these changes
Dec 5, 2018
|
@MartijnCuppens push the button if you agree. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noto Sansis expected to be considered a violation by the"font-family-name-quotes": "always-where-recommended"rule, but it does not seem to work for SCSS variables.