-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bump supported browsers for v5 #28317
Conversation
.browserslistrc
Outdated
Safari >= 9 | ||
Android >= 4.4 | ||
Opera >= 30 | ||
Chrome >= 70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't go there. IIRC the Google search bot is based on Chrome 47/48 or something like that. I need to find the source for this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found it: https://developers.google.com/search/docs/guides/rendering
Googlebot uses a web rendering service (WRS) that is based on Chrome 41 (M41)
Maybe by the time v5 stable is out this has changed, but until then, we shouldn't do this.
On the other hand we already use v45 here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI "The new evergreen Googlebot [...] now runs the latest Chromium rendering engine (74 at the time of this post) [...] Moving forward, Googlebot will regularly update its rendering engine"
Source: https://webmasters.googleblog.com/2019/05/the-new-evergreen-googlebot.html
And https://developers.google.com/search/docs/guides/fix-search-javascript does not specify anymore the Chrome version used by Googlebot
.browserslistrc
Outdated
iOS >= 10 | ||
Safari >= 10 | ||
Android >= 5 | ||
Opera >= 50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we should have Opera here at all. Opera is a Chromium based browser now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to be explicit though? Each browser has different functionality that comes with major versions, so we might want to review some of the milestones there to ensure we're not shooting ourselves in the foot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but why make an exception for Opera? I mean, we don't do the same for the other Chromium-based browsers.
BTW just thinking out loud here.
Also, perhaps it'd be wise to exclude some browsers explicitly. |
1355f1f
to
c9537ff
Compare
Is IE11 being kept around? Issue #28349 removes some IE leftovers but there's queries as to whether Bootstrap should work at all in IE11. Personally, it'd be easier to keep V4 for IE11 and use V5 (and beyond) to target more modern browsers. Now jQuery is being dropped it's possible to look into ESM (and maybe the JS can be shipped without being transpiled) but with IE11 that won't be possible. |
The issue with keeping v4 for IE11 is it also supports IE10. I'm hoping to see v5 work decent enough on IE11 with the recommended polyfills that I'll be able to justify moving to it instead of having to stick with v4 for the foreseeable future. |
cf09acd
to
05bf585
Compare
a79f16e
to
c5eb9a3
Compare
- Chrome history: https://en.wikipedia.org/wiki/Google_Chrome_version_history - Firefox latest ESR (v60): https://www.mozilla.org/en-US/firefox/organizations/ - Edge history: https://en.wikipedia.org/wiki/Microsoft_Edge#Release_history - Desktop Safari history: https://en.wikipedia.org/wiki/Safari_version_history - Opera history: https://help.opera.com/en/opera-version-history/
1b1a5a6
to
14eb6ac
Compare
14eb6ac
to
db7c050
Compare
Still WIP, but wanting to get this merged, so finding a slightly wider baseline
Hi. Since Android 5, Webview is available at its own apk (based in Chromium 75.0.3770.101 as of today), so it will be useful to support that OS version as well. |
WIP while we discuss, but wanted to use the PR to get the conversation going.
Fixes #28310