Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .form-group leftovers #29449

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

wojtask9
Copy link
Contributor

.form-group was removed in #28450

NOTE: Also removed whole label styling inside .form-inline and vertical-align from .form-control but I'm not sure about this. My tests shows that everything is OK but maybe my thinking is wrong.

@wojtask9 wojtask9 requested a review from a team as a code owner September 26, 2019 14:23
@wojtask9 wojtask9 changed the title remove form-group leftovers remove .form-group leftovers Sep 26, 2019
@MartijnCuppens
Copy link
Member

NOTE: Also removed whole label styling inside .form-inline and vertical-align from .form-control but I'm not sure about this. My tests shows that everything is OK but maybe my thinking is wrong.

Leave these changes for now, we'll probably gonna rely on the new grid to replace .form-inline (See #28517 or https://deploy-preview-28517--twbs-bootstrap.netlify.com/docs/4.3/forms/layout/#inline-forms)

Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the changes to .form-inline for now

@MartijnCuppens MartijnCuppens merged commit 043b054 into twbs:master Dec 9, 2019
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants