Switch to custom properties to control grid gutter widths #30475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Since we're using more and more custom properties, we'll be using more and more Unrelated thing, there's a flexbug fix L68 which only targets IE10-11. I'll do a PR latter. |
The reason we disallow them is because |
ffoodd
approved these changes
Mar 30, 2020
ffoodd
reviewed
Mar 30, 2020
MartijnCuppens
changed the title
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure yet how we should continue with the grid, so I'm just gonna make some improvements step by step which are easier to review/merge (unlike #28517 😛). In this PR I've switched to CSS custom properties which makes it easier to control the gutter width and saves a lot of CSS.
I've also moved the loop to save some media query prints.
CSS diff see: https://www.diffchecker.com/XRJUJMzm