-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: adds $nav-link-*
vars
#30498
wip: adds $nav-link-*
vars
#30498
Conversation
e8c5e65
to
a7fb882
Compare
$nav-link-color
$nav-link-color
I think we also need to add hover and active states as well. What do you think? |
5b8e005
to
81618fb
Compare
81618fb
to
5bb972d
Compare
Any suggestions theming wise? |
I'll come back here soon, this days. |
1b46fc5
to
e062656
Compare
$nav-link-color
$nav-link-*
vars
02209f8
to
7399051
Compare
Removed wip and rebased. |
LGTM. FWIW, I'd go with the active state too — even if the active state should not rely on color only (but this is another topic to tackle in Bootstrap and/or examples, I guess). @MartijnCuppens Do you agree, about an active state variable? |
Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.3.2 to 13.3.3. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](stylelint/stylelint@13.3.2...13.3.3) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [karma](https://github.com/karma-runner/karma) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v5.0.1...v5.0.2) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: XhmikosR <[email protected]>
Replaces #30498 by adding four new null default variables for .nav-link. Doesn't carry over font-style from the original PR though since that's rarely used, at least by default Bootstrap. Nullifies all values from that PR, too, since we count on some basic inheritance here and don't need color by default.
Closing for #31035. |
Replaces #30498 by adding four new null default variables for .nav-link. Doesn't carry over font-style from the original PR though since that's rarely used, at least by default Bootstrap. Nullifies all values from that PR, too, since we count on some basic inheritance here and don't need color by default.
Replaces twbs#30498 by adding four new null default variables for .nav-link. Doesn't carry over font-style from the original PR though since that's rarely used, at least by default Bootstrap. Nullifies all values from that PR, too, since we count on some basic inheritance here and don't need color by default.
This PR adds a new vars for
$nav-link-*
's:This PR depends on #30622