Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal: don't add margin & padding when sticky is not full width #30621

Merged
merged 5 commits into from
Feb 23, 2021
Merged

modal: don't add margin & padding when sticky is not full width #30621

merged 5 commits into from
Feb 23, 2021

Commits on Feb 19, 2021

  1. modal: don't add margin & padding when sticky is not full width

    @muhamadamin1992 @rohit2sharma95
    muhamadamin1992 authored and rohit2sharma95 committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    a788134 View commit details
    Browse the repository at this point in the history

  2. Update modal.spec.js

    @XhmikosR @rohit2sharma95
    XhmikosR authored and rohit2sharma95 committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    4c52f0c View commit details
    Browse the repository at this point in the history

  3. Check if element is shorter than window 

    - Update unit test as well
    @rohit2sharma95
    rohit2sharma95 committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    f4fef6c View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Merge branch 'main' into modal-with-sticky

    @rohit2sharma95
    rohit2sharma95 authored Feb 22, 2021
    Configuration menu
    Copy the full SHA
    a0b7db4 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Merge branch 'main' into modal-with-sticky

    @XhmikosR
    XhmikosR authored Feb 23, 2021
    Configuration menu
    Copy the full SHA
    af11a56 View commit details
    Browse the repository at this point in the history