Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parcel Bundler doc #30909

Merged
merged 6 commits into from
Feb 11, 2021
Merged

Add Parcel Bundler doc #30909

merged 6 commits into from
Feb 11, 2021

Conversation

eldk
Copy link
Contributor

@eldk eldk commented May 26, 2020

Hello,

Not sure if it helps but proposed.

Tested and used with V5 alpha.

Thanks,

Eric

Preview: https://deploy-preview-30909--twbs-bootstrap.netlify.app/docs/5.0/getting-started/parcel/

site/content/docs/5.0/getting-started/parcel.md Outdated Show resolved Hide resolved
site/content/docs/5.0/getting-started/parcel.md Outdated Show resolved Hide resolved
site/content/docs/5.0/getting-started/parcel.md Outdated Show resolved Hide resolved
site/content/docs/5.0/getting-started/parcel.md Outdated Show resolved Hide resolved
@XhmikosR
Copy link
Member

That being said, I'm not sure if this gives any value? I mean, it's the same procedure as webpack.

@XhmikosR XhmikosR added the docs label May 26, 2020
@eldk
Copy link
Contributor Author

eldk commented May 26, 2020

Hello,

That being said, I'm not sure if this gives any value? I mean, it's the same procedure as webpack.

Not at all.

Simply use this import 'bootstrap' don't work. I also needed to add as bootstrap to avoid building errors and have bootstrap js available (I don't remember the case).

You should check with (src/index.js - Parcel 6.14.5):

if (typeof bootstrap !== 'undefined' || bootstrap !== null) {
    console.log("Popover version : " + bootstrap.Popover.VERSION);
} else {
    console.log("index.js : Bootstrap undefined");
}

Thanks,

Eric

@XhmikosR
Copy link
Member

@mdo WDYT?

@XhmikosR XhmikosR self-requested a review May 26, 2020 16:44
@Johann-S
Copy link
Member

I'm not a big fan of doing a separate page for all the bundlers 🤔

@mdo
Copy link
Member

mdo commented May 30, 2020

I don't mind having separate pages for key tools and more from the ecosystem. If anything it boosts our visibility and usability across multiple communities and gives folks a solid starting point inside our own docs.

@mdo
Copy link
Member

mdo commented May 30, 2020

Pushed a bunch of updates to simplify and standardize:

  • Removed some headings, sentence cased some other headings
  • Removed the CSS snippets and defer folks to the extensive customize section w/ details on Sass
  • Combined and clarified JS import options
  • Buttoned up some copy

@XhmikosR
Copy link
Member

@mdo my only problem is listing this and parcel in Getting Started. We should probably add a parent submenu later.

Branch rebased.

{{< highlight json >}}
"scripts": {
"dev": "parcel ./src/index.html",
"prebuild": "rm -rf build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like rm -rf because it doesn't work on Windows.

Copy link
Contributor Author

@eldk eldk May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm aware of shx, but you don't use it here nor there is a comment that this won't work on vanilla Windows cmd :)

@mdo
Copy link
Member

mdo commented May 30, 2020

Yeah good point. And while we’re thinking about it, what else could we do for guides like this? Are there more languages and tools?

@XhmikosR
Copy link
Member

@mdo not sure but maybe we should land this after the Windows issue is sorted out, and we add a new parent page later.

@mdo mdo changed the base branch from master to main June 16, 2020 19:34
@XhmikosR
Copy link
Member

@eldk care to take care of the rm issue?

@eldk
Copy link
Contributor Author

eldk commented Oct 31, 2020

Hello @XhmikosR ,

I have no windows device, so I can't test it.

I think this should be used :

"prebuild": "rmdir /Q/S \"build\""

https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/rmdir
https://stackoverflow.com/questions/50696920/configuring-package-json-on-windows

Maybe should someone test it to confirm it's OK ?

Thanks,

Eric

@XhmikosR
Copy link
Member

XhmikosR commented Oct 31, 2020

@eldk now the docs will only work on Windows 😛 Maybe just go with npx rimraf build?

EDIT: scratch my first point since you added a s separate section. But I think with the npx solution we can make this cross-platform.

@eldk
Copy link
Contributor Author

eldk commented Oct 31, 2020

But I think with the npx solution we can make this cross-platform.

That's ok for me.

@eldk eldk requested a review from XhmikosR October 31, 2020 16:51
@XhmikosR XhmikosR requested a review from mdo November 1, 2020 05:17
@XhmikosR XhmikosR added the v5 label Nov 14, 2020
@XhmikosR XhmikosR changed the title Add Parcel-Bundler doc Add Parcel Bundler doc Nov 14, 2020
@mdo
Copy link
Member

mdo commented Nov 23, 2020

@XhmikosR Do we need this in the beta, or can it wait until v5 stable or v5.1.0?

@XhmikosR
Copy link
Member

It can wait, but it's ready I think. We could probably create a new subgroup named Bundlers and move Webpack and Parcel and whatever new shows up in the future, or leave it as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants