Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace .bg-white with .bg-body in docs #32815

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Replace .bg-white with .bg-body in docs #32815

merged 3 commits into from
Jan 25, 2021

Conversation

vinorodrigues
Copy link
Contributor

@vinorodrigues vinorodrigues commented Jan 16, 2021

Fixes #32810

Use of the .bg-white class to define visual aspects of the examples
would be unintuitive for theme builders to test themes on.
This replaces instances of .bg-white with .bg-body in the examples.

  • Edited examples to replace use .bg-white class with .bg-body class
    • product
    • offcanvas
    • pricing
    • cheatsheet
    • cheatsheet-rtl
  • Edited utilities colors.md & shadows.md to include .bg-body class

Response to issue #32810

Use of the .bg-white class to define visual aspects of the examples
would be unintuitive for theme builders to test themes on.
This replaces instances of .bg-white with .bg-body in the examples.

- Edited examples to replace use .bg-white class with .bg-body class
  - product
  - offcanvas
  - pricing
  - cheatsheet
  - cheatsheet-rtl
- Edited utilities colors.md & shadows.md to include .bg-body class
@mdo
Copy link
Member

mdo commented Jan 17, 2021

A docs mention has been added to #32819.

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdo mdo merged commit ba30df1 into twbs:main Jan 25, 2021
@vinorodrigues vinorodrigues deleted the fix-docs-bg-white branch January 26, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of .bg-white class in docs makes theming difficult in v5 - replace with .bg-body
3 participants