Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): input-group and validation icons #32968

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Feb 2, 2021

Fixes #30131

Issue mentions .form-control but it also impacts .custom-select — but not textarea (as you may see in this reduced test case) since it has a qualifying type selector that increases its specificity.

So another way could be to set select.custom-select and input.form-control. Would there be any other tag concerned by those classes?

Fixes #30131

Issue mentions `form-control` but it impacts `.custom-select` — but not `textarea` since it has a qualifying type selector that increases its specificty.

So another way could be to set `select.custom-select` and `input.form-control`. Would there be any other tag concerned by those classes?
@ffoodd ffoodd requested a review from a team as a code owner February 2, 2021 14:45
@mdo
Copy link
Member

mdo commented Feb 11, 2021

Not stoked about the !important, but yeah we're kind of in a bind here. Feels like we can excuse it because validation states should be made clear no matter the content or styling of the field... any other thoughts?

@ffoodd
Copy link
Member Author

ffoodd commented Feb 11, 2021

IMHO !important is the most appropriate fix for this. Only increases a single property's specificity, whereas using qualifying selectors would increase every styles hooked there.

And I don't think we should spend time to work around this, since it's only in v4. Going further might lead to smuch more side effects.

@XhmikosR XhmikosR merged commit 030af97 into v4-dev Feb 15, 2021
@XhmikosR XhmikosR deleted the v4-dev-fod-validation-input-group branch February 15, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants