Change the name of the Offcanvas constructor
#33261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything should be |
rohit2sharma95
force-pushed
the
rohit/offcanvas-name
branch
from
0cff430
to
14c484c
Compare
rohit2sharma95
changed the title
Offcanvas constructor
XhmikosR
force-pushed
the
rohit/offcanvas-name
branch
from
69452a1
to
309def0
Compare
XhmikosR
approved these changes
Mar 16, 2021
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not
Offcanvas, it isOffCanvas.I am not sure if it should be changed from
OffCanvastoOffcanvasin the js files. Since @mdo said in the comment, I'm leaving everything asoffcanvas, from source code to usage in the docs.