Modal.js: fix test for scrollbar #33666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpadev
reviewed
Apr 17, 2021
|
Likely better that way. When the modal is shown there is expected to be overflow hidden on the body so getScrollbarWidth would return 0. 👍 |
GeoSot
force-pushed
the
gs-minor-fix-on-test
branch
from
d0eea47
to
cc312ae
Compare
GeoSot
force-pushed
the
gs-minor-fix-on-test
branch
from
cc312ae
to
e7d0f54
Compare
|
I rerun the CI jobs a few times and it seems to be passing consistently. |
XhmikosR
approved these changes
Apr 18, 2021
This was referenced Jul 12, 2024
This was referenced Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the timing of
scrolllbarGetWidthon test