Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accordion: fix border-top on Firefox #33736

Merged
merged 3 commits into from
Apr 30, 2021
Merged

accordion: fix border-top on Firefox #33736

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ffe3bf
refactor: adapt border-top instead of negative margin
alpadev Apr 23, 2021
7e4e2e8
Merge branch 'main' into change-accordion-border
XhmikosR Apr 25, 2021
9f5d789
Merge branch 'main' into change-accordion-border
XhmikosR Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scss/_accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
}

.accordion-item {
margin-bottom: -$accordion-border-width;
background-color: $accordion-bg;
border: $accordion-border-width solid $accordion-border-color;

Expand All @@ -70,9 +69,12 @@
}
}

&:not(:first-of-type) {
border-top: 0;
}

// Only set a border-radius on the last item if the accordion is collapsed
&:last-of-type {
margin-bottom: 0;
@include border-bottom-radius($accordion-border-radius);

.accordion-button {
Expand Down