-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Tab keyboard functionality after #37146 #37200
Conversation
I haven't followed the topic around 1510c25 but I can confirm that this PR fixes the behaviour mentioned in the description and is back to normal as it was in the v5.2. |
confirming that, based on the live preview, this works as it should. assuming that this does not reintroduce the problem noted in #37107, and that the JS tests all still make sense, this looks good to me |
5506c3b
to
a6284c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
After
1510c25.
https://twbs-bootstrap.netlify.app/docs/5.2/components/navs-tabs/#javascript-behavior,
@julien-deramond pointed out:
/cc @patrickhlauke
Type of changes
Checklist
npm run lint
)Live previews