Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix negative border-width on inputgroup and buttongroup #37356

Merged
merged 1 commit into from
Oct 23, 2022
Merged

fix negative border-width on inputgroup and buttongroup #37356

merged 1 commit into from
Oct 23, 2022

Conversation

jonnysp
Copy link
Contributor

@jonnysp jonnysp commented Oct 23, 2022 •
edited by julien-deramond
Loading

Description

fixes bugs from my previous changes, the variable border-width.

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related PR

#37344

@jonnysp jonnysp requested a review from a team as a code owner October 23, 2022 06:30
@jonnysp jonnysp changed the title fix negative border-width on inputgroup fix negative border-width on inputgroup and buttongroup Oct 23, 2022
@julien-deramond
Copy link
Member

Thanks for the PR @jonnysp. Could you explain in the description the use case fixed with some examples?

@jonnysp
Copy link
Contributor Author

jonnysp commented Oct 23, 2022 •
edited
Loading

fixes bugs from my previous changes, the variable border-width. (between the inputs)
https://deploy-preview-37344--twbs-bootstrap.netlify.app/docs/5.2/forms/input-group/

@mdo mdo merged commit db60ae0 into twbs:main Oct 23, 2022
@jonnysp jonnysp deleted the fix-border-with-variable-on-input-group-an-btn-group branch October 23, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonnysp @julien-deramond @mdo