Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add margin between buttons in tooltip examples #37492

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 14, 2022

Description

This PR suggests to add some margin around the buttons used in Docs > Tooltips > Directions example. The values used are the same as the one used in the standard buttons example:

> .btn,
> .btn-group {
  margin: .25rem .125rem;
}

The Cheatsheet example is not impacted by this change because it has its own margin rules:

[id="tooltips"] .bd-example .btn {
  margin: 0 1rem 1rem 0;
}

Motivation & Context

This change adds some space around the buttons when the screen width is reduced to avoid:
Screenshot 2022-11-14 at 08 32 48

Type of changes

  • Enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

Related issues

N/A

@mdo mdo merged commit f97149a into main Nov 14, 2022
@mdo mdo deleted the main-jd-add-margin-between-buttons-in-tooltip-examples branch November 14, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants