Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use child combinators to avoid inheriting parent accordion's flush styles #37508

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Use child combinators to avoid inheriting parent accordion's flush styles #37508

merged 10 commits into from
Nov 17, 2023

Conversation

nkdas91
Copy link
Contributor

@nkdas91 nkdas91 commented Nov 17, 2022 •
edited by patrickhlauke
Loading

Description

Use child combinators to avoid inheriting parent accordion's flush styles

Motivation & Context

Fixes #37455

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

No changes in documentation
https://deploy-preview-37508--twbs-bootstrap.netlify.app/docs/5.3/components/accordion/

Code Pen
https://codepen.io/nkdas91/pen/VwdMXVm

Related issues

#37455

@nkdas91 nkdas91 requested a review from a team as a code owner November 17, 2022 07:11
patrickhlauke
patrickhlauke approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

@taesungh taesungh mentioned this pull request Jan 1, 2023
Closed
3 tasks
mdo
mdo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me if you agree @julien-deramond

julien-deramond
julien-deramond approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no regression by testing different nesting and regular use cases. LGTM! Thanks for the PR!

@julien-deramond julien-deramond merged commit ee88ae6 into twbs:main Nov 17, 2023
14 checks passed
@nkdas91 nkdas91 deleted the accordion branch November 17, 2023 14:01
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@nkdas91 @patrickhlauke
@julien-deramond @romankupchak93
Use child combinators to avoid inheriting parent accordion's styles (t…
058b904 
…wbs#37508)

Co-authored-by: Patrick H. Lauke <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
@ZuBB ZuBB mentioned this pull request Feb 21, 2024
Merged
10 tasks
@damian-snyk damian-snyk mentioned this pull request Apr 19, 2024
Open
@CGrabda CGrabda mentioned this pull request May 17, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 18, 2024
Open
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
This was referenced May 19, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
@Identian Identian mentioned this pull request May 20, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Sep 29, 2024
Open
@DeFiTON DeFiTON mentioned this pull request Sep 30, 2024
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
@YnnusAsamal YnnusAsamal mentioned this pull request Sep 30, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Sep 30, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 1, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 1, 2024
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 4, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 5, 2024
Open
Open
This was referenced Oct 12, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 13, 2024
Open
This was referenced Oct 15, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 20, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 22, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 27, 2024
Open
This was referenced Oct 29, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Nov 3, 2024
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@patrickhlauke patrickhlauke patrickhlauke approved these changes

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested accordion inherits parent's flush styling
4 participants
@nkdas91 @mdo @patrickhlauke @julien-deramond