Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop logo on homepage on mobile #37608

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Drop logo on homepage on mobile #37608

merged 1 commit into from
Dec 26, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Dec 7, 2022

Description

Identified as a sub-task of #37549, this PR suggests to drop the logo on homepage on mobile (portrait).

Type of changes

  • Enhancement

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

Related issues

Linked to #37549

@julien-deramond julien-deramond mentioned this pull request Dec 7, 2022
81 tasks
@julien-deramond julien-deramond marked this pull request as ready for review December 7, 2022 21:37
@XhmikosR
Copy link
Member

Just wondering, why is this an issue with dark mode?

@julien-deramond
Copy link
Member Author

I believe that @mdo added this item in the list while we were testing the light/dark mode on different devices. It's not directly linked to the dark mode indeed.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️🤘🏻

@mdo mdo merged commit 21956ee into main Dec 26, 2022
@mdo mdo deleted the main-jd-drop-home-logo-on-mobile branch December 26, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants