Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix accordion flush description #37798

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 3, 2023

Description

Based on the elements from #37776 (comment), IMO the current background color management is OK since it provides some security regarding a11y and contrast if the accordions (or list groups) are included in another parent container with a different background color.

So this PR suggests to only remove a part of the sentence and to get close to the one in https://getbootstrap.com/docs/5.3/components/list-group/#flush.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #37776

@julien-deramond julien-deramond marked this pull request as ready for review January 3, 2023 17:06
@mdo mdo merged commit f692ecd into main Jan 4, 2023
@mdo mdo deleted the main-jd-fix-accordion-flush-doc branch January 4, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

.accordion-flush does not remove background-color
2 participants