Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop duplicate --bs-body-bg-rgb declaration + reorder props #37857

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 11, 2023

Description

The main purpose of this PR is to drop a duplicate declaration of our --bs-body-bg-rgb.

--#{$prefix}body-bg-rgb: #{to-rgb($body-bg)};

--#{$prefix}body-bg-rgb: #{to-rgb($body-bg)};

While doing it, I grouped together --bs-body-* props within root-body-variables section.

Note: originally found out by @louismaximepiton. Thanks!

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

@mdo mdo merged commit 47580ff into main Jan 11, 2023
@mdo mdo deleted the main-jd-drop-dupe-body-bg-rgb branch January 11, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants