Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Proposal to add a border utility #37905

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 17, 2023

Description

Add .border-black.

Motivation & Context

We have .text-black and .text-white. We have .bg-black and .bg-white.
Just felt weird having .border-white and no .border-black. Maybe the .border-white could be removed instead of adding the black one ?

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@mdo
Copy link
Member

mdo commented Jan 18, 2023

I dig, thanks!

@louismaximepiton louismaximepiton deleted the main-lmp-border-black branch January 18, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants