Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version from index.{esm,umd}.js too #38302

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Remove version from index.{esm,umd}.js too #38302

merged 3 commits into from
Mar 22, 2023

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 22, 2023 •
edited
Loading

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Followup to #38294

@XhmikosR XhmikosR added the js label Mar 22, 2023
@XhmikosR XhmikosR marked this pull request as ready for review March 22, 2023 08:20
@XhmikosR XhmikosR requested a review from a team as a code owner March 22, 2023 08:20
@XhmikosR XhmikosR merged commit 842fd50 into main Mar 22, 2023
@XhmikosR XhmikosR deleted the xmr/js-rm-ver branch March 22, 2023 08:23
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XhmikosR