Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix incorrect class name on migration guide #38883

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Docs: Fix incorrect class name on migration guide #38883

merged 1 commit into from
Jul 10, 2023

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jul 10, 2023

Description

There wasn't a Bootstrap v4 class called .form-file - it was .form-control-file.

REF: https://getbootstrap.com/docs/4.6/dist/css/bootstrap.css

Motivation & Context

Help users upgrading by finding the right file in their code.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

There wasn't a class called `.form-file - it was `.form-control-file`.

REF: https://getbootstrap.com/docs/4.6/dist/css/bootstrap.css
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coliff, good catch!

@julien-deramond julien-deramond merged commit 42a055c into twbs:main Jul 10, 2023
@coliff coliff deleted the patch-3 branch July 10, 2023 08:15
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants