Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop --bs-accordion-btn-focus-border-color and deprecate $accordion-button-focus-border-color #39560

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 3, 2024

Description

As discussed in https://github.com/orgs/twbs/discussions/39559, accordion button's border width is set to 0 and is never changed afterwards. The focus state is handled by a box-shadow.

Based on these elements, this PR:

  • Remove the border-color rule from the focused .accordion-button
  • Remove useless --bs-accordion-btn-focus-border-color
  • Deprecate unused $accordion-button-focus-border-color

This might be referenced in the blog post.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@julien-deramond julien-deramond marked this pull request as ready for review January 3, 2024 08:36
@julien-deramond julien-deramond requested a review from a team as a code owner January 3, 2024 08:36
@XhmikosR XhmikosR merged commit 4e35f64 into main Feb 6, 2024
12 checks passed
@XhmikosR XhmikosR deleted the main-jd-deprecate-accordion-focus-border-color branch February 6, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants