-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed end of transition event for IE 10 (Windows 8) #4015
Conversation
Have you taken a look at |
@mckramer The problem is that |
…operties in bootstrap-transition.js
@@ -37,8 +37,8 @@ | |||
'WebkitTransition' : 'webkitTransitionEnd' | |||
, 'MozTransition' : 'transitionend' | |||
, 'OTransition' : 'oTransitionEnd' | |||
, 'msTransition' : 'MSTransitionEnd' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both, MSTransitionEnd
and transitionend
, do exist in IE10 but the former won't be ever called!
Hey @ComFreek, Thanks for opening this pull-request! Unfotunately, it looks like it fails to pass the tests neccessary for submitting to bootstrap. The following tests are currently failing:
For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines. thanks! |
@fat Should be OK, now. |
@ComFreek hey bud, @jonathansampson has a similar fix. #4109 Could you check it out? Using the non-MS prefixed property is a better route based on what we put out in IE10. |
@reybango I don't know whether |
@ComFreek IE<10 doesn't support transitions so it should be fine. |
Removed the prefixed values since IE10 doesn't require/support them in full any longer. 2a0cf0f |
Fix for my issue #4011: #4011