Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed end of transition event for IE 10 (Windows 8) #4015

Closed
wants to merge 3 commits into from
Closed

Fixed end of transition event for IE 10 (Windows 8) #4015

wants to merge 3 commits into from

Conversation

ComFreek
Copy link

@ComFreek ComFreek commented Jul 6, 2012

Fix for my issue #4011: #4011

@travisbot
Copy link

This pull request passes (merged 729b486 into 857b8fb).

@mckramer
Copy link
Contributor

mckramer commented Jul 6, 2012

Have you taken a look at bootstrap-transition.js?

@ComFreek
Copy link
Author

ComFreek commented Jul 6, 2012

@mckramer The problem is that mstransitionend doesn't work under IE 10, you have to use transitionend. Maybe, we could check for IE 10 in bootstrap-transition.js?

@travisbot
Copy link

This pull request passes (merged a8d2985 into 857b8fb).

@travisbot
Copy link

This pull request passes (merged 7c8e33f into 857b8fb).

@@ -37,8 +37,8 @@
'WebkitTransition' : 'webkitTransitionEnd'
, 'MozTransition' : 'transitionend'
, 'OTransition' : 'oTransitionEnd'
, 'msTransition' : 'MSTransitionEnd'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both, MSTransitionEnd and transitionend, do exist in IE10 but the former won't be ever called!

@fat
Copy link
Member

fat commented Jul 22, 2012

Hey @ComFreek,

Thanks for opening this pull-request! Unfotunately, it looks like it fails to pass the tests neccessary for submitting to bootstrap. The following tests are currently failing:

  • should always be made against -wip branches
  • should always include a unit test if changing js files

For a full list of issue filing guidelines, please refer to the bootstrap issue filing guidelines.

thanks!

@fat fat closed this Jul 22, 2012
@ComFreek
Copy link
Author

@fat Should be OK, now.

@reybango
Copy link

@ComFreek hey bud, @jonathansampson has a similar fix. #4109 Could you check it out? Using the non-MS prefixed property is a better route based on what we put out in IE10.

@ComFreek
Copy link
Author

@reybango I don't know whether transitionend is supported by IE<10! So I think we should keep them both, but in different order (as I committed). Or are there any disadvantages?

@reybango
Copy link

@ComFreek IE<10 doesn't support transitions so it should be fine.

@jonathansampson
Copy link
Contributor

Removed the prefixed values since IE10 doesn't require/support them in full any longer. 2a0cf0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants