-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BS3: Restore Glyphicons #9767
BS3: Restore Glyphicons #9767
Conversation
<a href="#glyphicons">Glyphicons</a> | ||
<ul class="nav"> | ||
<li><a href="#glyphicons-glyphs">Available glyphs</a></li> | ||
<li><a href="#glyphicons-how-to-use">How ot use</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "ot"
The bootstrap-glyphicons repo has a few open issues regarding vertical alignment.. |
Updated all those other issues and nuked the repo. |
Please also consider adding This is a comparison screenshot (fontawesome): FortAwesome/Font-Awesome#1591 (comment) |
@mdo, the picture above.... :-) |
Negates #8332. |
Conflicts: dist/css/bootstrap.min.css
HOOORAYYYYYYY IT'S BACKKKKK |
Surprised to have found http://glyphicons.getbootstrap.com/css/bootstrap-glyphicons.css suddenly 404. Problem I can see... Please advise: have these icons not been included with the distribution or is there a problem that will be sorted? |
You can host your own or use a CDN but you should never use the files used by the docs. |
Icons have been updated per #9808. |
I suppose you should split Gylphicons into separate css, as bootstrap-theme.css for gradients. Thus they would be supplied within main dist, but optional for including. |
Hooray, glyphicons |
BS3: Restore Glyphicons
BS3: Restore Glyphicons
After going back and forth on this for the last couple weeks, I've decided to restore the Glyphicons icon font to the main repo. Given how prevalent icons are in UIs, it's probably a disservice to most folks to not include them (or some other icon font) in the same spot as the CSS and JS.
With this update comes the following:
@icon-font-path
and@icon-font-name
, for flexibility in adding and removing icon fontsWe'll work on improving the customization of icon fonts in the future so swapping font libraries can be easier (which was the whole motivation for the original removal).