Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS3: Restore Glyphicons #9767

Merged
merged 9 commits into from
Aug 18, 2013
Merged

BS3: Restore Glyphicons #9767

merged 9 commits into from
Aug 18, 2013

Conversation

mdo
Copy link
Member

@mdo mdo commented Aug 18, 2013

mpw-49999

After going back and forth on this for the last couple weeks, I've decided to restore the Glyphicons icon font to the main repo. Given how prevalent icons are in UIs, it's probably a disservice to most folks to not include them (or some other icon font) in the same spot as the CSS and JS.

With this update comes the following:

  • Restores documentation (on the Components page)
  • New variables, @icon-font-path and @icon-font-name, for flexibility in adding and removing icon fonts
  • Upgrades to latest Glyphicons (adding 40 new icons)
  • Removes the old Glyphicons mention from the CSS page

We'll work on improving the customization of icon fonts in the future so swapping font libraries can be easier (which was the whole motivation for the original removal).

<a href="#glyphicons">Glyphicons</a>
<ul class="nav">
<li><a href="#glyphicons-glyphs">Available glyphs</a></li>
<li><a href="#glyphicons-how-to-use">How ot use</a></li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "ot"

@cvrebert
Copy link
Collaborator

The bootstrap-glyphicons repo has a few open issues regarding vertical alignment..

@mdo
Copy link
Member Author

mdo commented Aug 18, 2013

Updated all those other issues and nuked the repo.

@tagliala
Copy link
Contributor

Please also consider adding -moz-osx-font-smoothing: grayscale;: https://bugzilla.mozilla.org/show_bug.cgi?id=857142#c83

This is a comparison screenshot (fontawesome): FortAwesome/Font-Awesome#1591 (comment)

@Merg1255
Copy link

@mdo, the picture above.... :-)

@cvrebert
Copy link
Collaborator

Negates #8332.

Conflicts:
	dist/css/bootstrap.min.css
mdo added a commit that referenced this pull request Aug 18, 2013
@mdo mdo merged commit d7eee9b into 3.0.0-wip Aug 18, 2013
@mdo mdo deleted the bs3_restore_glyphicons branch August 18, 2013 17:35
@josephers
Copy link

HOOORAYYYYYYY IT'S BACKKKKK

@robertandrews
Copy link

Surprised to have found http://glyphicons.getbootstrap.com/css/bootstrap-glyphicons.css suddenly 404.
So I guess the idea is to have Gylphicons CSS and icons hosted on our sites?

Problem I can see...
Several icons seem missing/malformed. These appear as boxes, both on my side and in the BS3 docs for Available Glyphs (http://getbootstrap.com/components/#glyphicons-glyphs). They are...
.glyphicon .glyphicon-lock
.glyphicon .glyphicon-bookmark
.glyphicon .glyphicon-camera
.glyphicon .glyphicon-fire
.glyphicon .glyphicon-bell
.glyphicon .glyphicon-wrench
.glyphicon .glyphicon-briefcase

Please advise: have these icons not been included with the distribution or is there a problem that will be sorted?

@cebe
Copy link

cebe commented Aug 18, 2013

Surprised to have found http://glyphicons.getbootstrap.com/css/bootstrap-glyphicons.css suddenly 404.
So I guess the idea is to have Gylphicons CSS and icons hosted on our sites?

You can host your own or use a CDN but you should never use the files used by the docs.

@mdo
Copy link
Member Author

mdo commented Aug 18, 2013

Icons have been updated per #9808.

@guigs guigs mentioned this pull request Aug 19, 2013
6 tasks
@Nilard
Copy link

Nilard commented Aug 21, 2013

I suppose you should split Gylphicons into separate css, as bootstrap-theme.css for gradients. Thus they would be supplied within main dist, but optional for including.

@cydrobolt
Copy link

Hooray, glyphicons

stempler pushed a commit to stempler/bootstrap that referenced this pull request Apr 11, 2014
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants