Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated HTTPS html5shiv URL #315

Merged
merged 1 commit into from
Feb 28, 2014
Merged

use updated HTTPS html5shiv URL #315

merged 1 commit into from
Feb 28, 2014

Conversation

cvrebert
Copy link
Contributor

Pretty sure that the Google Code html5shiv URL/project is deprecated.

@cvrebert cvrebert added the js label Feb 26, 2014
@mdo
Copy link
Member

mdo commented Feb 26, 2014

Do we even need this?

Edit: As in, do we need to have a shiv if we don't intend to support IE8?

@cvrebert
Copy link
Contributor Author

AFAIK, nope.

@XhmikosR
Copy link
Member

The docs page should work in old IE. Even Google supports IE8.

If we decide that IE8 is no longer supported, we should show a nice message, similarly to what html5 boilerplate does.

@XhmikosR XhmikosR added docs and removed docs labels Feb 27, 2014
@cvrebert
Copy link
Contributor Author

Since this is at least a definite improvement over the status quo, I'm gonna just merge this, and someone can take up the matter of IE8 docs support / shiv usage in a new issue if they want.

cvrebert added a commit that referenced this pull request Feb 28, 2014
use updated HTTPS html5shiv URL
@cvrebert cvrebert merged commit bd509d4 into master Feb 28, 2014
@cvrebert cvrebert deleted the html5shim branch February 28, 2014 03:35
@cvrebert cvrebert added this to the 2.0.1 milestone Feb 28, 2014
@cvrebert cvrebert added css and removed css labels Feb 28, 2014
@XhmikosR
Copy link
Member

👍

@mdo mdo mentioned this pull request Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants