Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to netstandard 1.0 #22

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Port to netstandard 1.0 #22

merged 1 commit into from
Mar 13, 2017

Conversation

jarroda
Copy link
Contributor

@jarroda jarroda commented Mar 11, 2017

This PR ports the project to netstandard 1.0. The library is configured to compile to both .net 4.5 and netstandard 1.0, so backwards compatibility should be maintained.

Additionally I ported the test project over and all tests pass that did before, with the same 18 tests failing.

I am using the .NET Core 1.0.0 SDK - Preview 2.1 (build 003177) tooling.

Once merged, this should address #6 and #13

@RichiCoder1
Copy link

Is there a reason you're not using the latest tools? Project.json is officially deprecated as of this point.

@jarroda
Copy link
Contributor Author

jarroda commented Mar 12, 2017

@RichiCoder1 Yeah the reason is that I do all my work on macos using VSCode and CLI tooling, and my attempts at using the msbuild based tooling (a couple of weeks ago) found it to be bug-filled and woefully unproductive. I realize a new release was put out on the 7th, but I haven't had time to mess with it.

If you'd like to convert it to the most recent tooling, feel free to pitch in. Opening the solution in VS 2017 will convert it automatically I presume.

@RichiCoder1
Copy link

Yup. There's also dotnet migrate. Luckily the auto conversion has much improved since then. Will look into it.

@aidanbebbington aidanbebbington merged commit 20c6d0d into twcclegg:master Mar 13, 2017
@aidanbebbington
Copy link
Collaborator

Thanks for this! I've just opened it up in VS2017 which converted things it seems. I've done some basic smoke tests and updated the nuget package. Let me know if it doesn't work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants