Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target .NET 8.0 and drop .NET 7.0 #264

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Target .NET 8.0 and drop .NET 7.0 #264

merged 3 commits into from
Aug 23, 2024

Conversation

filipw
Copy link
Contributor

@filipw filipw commented Aug 23, 2024

Hello 👋 This PR updates the targeting of the library.

Changes

  • .NET 8.0 is now explicitly targeted by the "main" library. It was already used in tests, but the main one only targeted 6, 7 and .NET Standard 2.0.
  • .NET 7.0 was removed as it reached the end of life in May 2024

Without this, using the library on .NET 8.0 means going over .NET Standard 2.0 which in turn pulls a ton of very old (dating back to 2016) dependencies via System.IO.Compression, some of which even have CVEs on them.

@twcclegg
Copy link
Owner

Thanks!

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (9ca9181) to head (494485f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files          34       34           
  Lines        4424     4424           
  Branches     1001     1001           
=======================================
  Hits         3330     3330           
  Misses        885      885           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twcclegg twcclegg merged commit d30d7f0 into twcclegg:main Aug 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants