Add Equal contract to the stdlib #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
force-pushed
the
feature/equal-contract
branch
from
a1b32b3
to
f488f9f
Compare
Add an Equal contract to the stdlib, which checks that the value is equal to some constant. This contracts try to preserve laziness, in that checks are delayed for arrays and records in principle. Caution: currently, the lazy check isn't implemented for record, so this contract is actually just `fun c => from_predicate ((==) c)` when `c` is a record, temporarily.
yannham
force-pushed
the
feature/equal-contract
branch
from
f488f9f
to
e53a422
Compare
vkleen
approved these changes
Mar 28, 2023
Fix typos in the code documentation Co-authored-by: Viktor Kleen <[email protected]>
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #935, and #1199 (comment) (meaning this PR is required before tackling #1187), this PR introduces an
Equalcontract to the stdlib, which simply checks that the tested value equals to some constant provided as a parameter to the contract. TheEqualcontract should preserve laziness over arrays and records.As per #1199 (comment) and the following comment, this is probably required to fix #1187. This PR doesn't deal with records lazily yet, as it might require a new primop to properly preserve recursiveness (if we use record.map, then we're going to kill recursive references, which is not expected from contracts). This is planned as an immediate follow-up, but this chunk is already reviewable and functional.