Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add %eval_nix% primop #1465

Merged
merged 32 commits into from
Oct 9, 2023
Merged

add %eval_nix% primop #1465

merged 32 commits into from
Oct 9, 2023

Conversation

Radvendii
Copy link
Member

add an %eval_nix% primop which calls out to the nix C++ bindings. At the moment, this goes through JSON and therefore requires the nix to fully evaluate

Partly addresses #1431

@github-actions github-actions bot temporarily deployed to pull request July 20, 2023 15:09 Inactive
core/build.rs Outdated Show resolved Hide resolved
core/src/term/mod.rs Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request July 24, 2023 13:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2023 16:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2023 18:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2023 19:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2023 19:37 Inactive
flake.nix Outdated Show resolved Hide resolved
core/src/eval/operation.rs Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 2, 2023 15:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 3, 2023 18:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 4, 2023 13:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 8, 2023 10:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 14:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 15:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 23:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 16, 2023 07:40 Inactive
Copy link
Contributor

@vkleen vkleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can make the flake outputs more configurable to avoid the heavy dependency footprint in e.g. nix run github:tweag/nickel if one is just looking for a minimal Nickel interpreter. But that's probably better tackled in a separate PR.

@github-actions github-actions bot temporarily deployed to pull request August 22, 2023 15:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 22, 2023 17:39 Inactive
Copy link
Member

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The footprint isn't as bad as I thought (it doesn't add to much nix-experimental-related code).

core/src/error.rs Outdated Show resolved Hide resolved
core/src/error.rs Outdated Show resolved Hide resolved
core/src/error.rs Outdated Show resolved Hide resolved
core/src/nix_ffi/cpp/nix.cc Show resolved Hide resolved
flake.nix Show resolved Hide resolved
@yannham
Copy link
Member

yannham commented Sep 8, 2023

@Radvendii is there anything left to do to merge this PR (beside rebasing, now there's a conflict)? I fear this drifts further away from master

@github-actions github-actions bot temporarily deployed to pull request October 5, 2023 23:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 6, 2023 00:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 6, 2023 01:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 6, 2023 03:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 6, 2023 03:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 6, 2023 03:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 6, 2023 18:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 9, 2023 11:55 Inactive
@Radvendii
Copy link
Member Author

There's a phantom bug which only occurs in CI, Not even on my local x86_64-darwin machine which is using the same version of nix to build , and building the same derivation.

I tried to track down the phantom bug using valgrind, but the nix package for valgrind is broken, and when I used an old version it didn't actually work. It seems from internet searches that valgrind is just kind of broken on mac os?

Given that this is only a problem with a single test, I've filed the bug with upstream and disabled tests for now.

@Radvendii Radvendii added this pull request to the merge queue Oct 9, 2023
Merged via the queue into master with commit 91d63ed Oct 9, 2023
5 checks passed
@Radvendii Radvendii deleted the eval_nix branch October 9, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants