Fix unbound identifier when querying in REPL #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following a refactoring that landed in 1.4, the current environment of a REPL session wasn't taken into account when querying an expression. This mean that any value introduced by a toplevel let during the session would evaluate fine but raise an unbound identifier error if one tries to query it with `:query some_id`. This commit fixes this by correctly propagating the environment in the subfunctions involved in querying.
vkleen
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1842
Following a refactoring that landed in 1.4, the current environment of a REPL session wasn't taken into account when querying an expression. This means that any value introduced by a toplevel let during the session would evaluate fine but would raise an unbound identifier error if one tries to query it with
:query some_id.This commit fixes this by correctly propagating the environment in the subfunctions involved in querying.