Fix LSP not showing type signature in untyped code #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneem
reviewed
Apr 12, 2024
jneem
approved these changes
Apr 12, 2024
Most of the time, hovering over a symbol in untyped code would show `Dyn` even though the symbol has a type annotation - in particular for records accessed via a non-trivial path, e.g. `foo.bar.baz`. This is an issue because in particular, we don't get to see the right types for stdlib symbols when hovering over them. This commit fixes the issue by taking the type annotation instead of the type provided by the typechecker when the latter is `Dyn`.
yannham
force-pushed
the
fix/lsp-show-type-annot
branch
from
2ebe6b8
to
d431131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time, hovering over a symbol in untyped code would show
Dyneven though the symbol has a type annotation - typically for records accessed via a non-trivial path, e.g.foo.bar.baz. This is an issue especially because we don't get to see the right types for stdlib symbols when hovering over them.This PR fixes the issue by taking the type annotation (technically one of the aggregated type annotations) instead of the type provided by the typechecker when the latter is
Dyn.