-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake: remove redundant transitive dependencies #1986
Conversation
- add several more `follows` relationships for de-duplication - update to latest rust-overlay flake which drops flake-utils dependency - set `follows = ""` for a few unused dependencies. See NixOS/nix#7807
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it does trim the flake.lock quite a bit.
What do you think about NixOS/nix#7807 (comment), related to follows = ""
? I'm a bit reluctant with those kind of hacks, because if somebody else has to handle a CI breakage (say, upon a flake.lock update) and don't know about it, it can turn out to be painful.
I was conflicted about it. I think it's quite reasonable to not use |
@jeremyschlatter Thanks. I believe there's still one empty follows for the |
@yannham Whoops, thanks for catching that. Fixed. |
I'm taking over here. There are unrelated clippy failures (this change induced a flake.lock update, and the rustc version was bumped, which made clippy more restrictive), and some of them (e.g. the transmute) aren't trivial to fix. |
I added the
github:tweag/nickel
flake to a project today and noticed that it pulled in a bunch of redundant transitive dependencies. This commit cleans those up. The impact is visible in the lock file, which now has 13 fewernodes
:Things done:
added several more
follows
relationships for de-duplicationupdated to latest rust-overlay flake which drops flake-utils dependency
set
follows = ""
for a few unused dependencies. See null flake input NixOS/nix#7807.