Optimize std.contract.Equal using %record/split_pair%
#1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The std.contract.Equal contract needs to be lazy, which means that it re-implement equality logic in pure Nickel code, which has proven to be very slow (#1930). This commit replaces the field difference operation, implemented using a left fold, by the new builtin operator `%record/split_pair%`, which shows a performance improvement of around 300% for the example of #1930.
jneem
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std.contract.Equal contract needs to be lazy, which means that it re-implements equality logic in pure Nickel code, which has proven to be very slow (#1930).
This commit replaces the field difference operation, implemented using a left fold, by the new builtin operator
%record/split_pair%, which shows a performance improvement of around 300% for the example of #1930.