-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation for subtyping #1990
Merged
yannham
merged 28 commits into
tweag:master
from
Eckaos:subtyping/Record_Dictionary_Documentation_Tests
Jul 29, 2024
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
35ff633
Add subsumption rule between Record/Dictionary
Eckaos abbbe1f
Remove commented code
Eckaos 00a9537
Remove clone in pattern match, replaced fold by a for loop, take into…
Eckaos c99634e
Update & add comments
Eckaos bb20fc9
Add integration tests
Eckaos 9e0f0e4
add test with chaining std function on records
Eckaos f6cd3ab
add manual documentation for record/dictionary subtyping
Eckaos bfeb094
Merge branch 'tweag:master' into subtyping/Record_Dictionary_Document…
Eckaos 6bb2e6a
Merge branch 'tweag:master' into subtyping/Record_Dictionary_Document…
Eckaos 871a0bf
Modify manual
Eckaos 65ed749
Changing contract to typing
Eckaos af81a9f
Update core/tests/integration/inputs/typecheck/chaining_dictionary_fu…
Eckaos a71465e
Update doc/manual/typing.md
Eckaos a95489e
Fix test
Eckaos 4c8b493
Add motivation
Eckaos 9709082
Merge branch 'tweag:master' into subtyping/Record_Dictionary_Document…
Eckaos 2d7a14b
Fix code example
Eckaos 759eafb
Add Array/Array and Dictionary/Dictionary subtyping documentation
Eckaos d0b1a1e
Fix code (does not fix TypecheckError)
Eckaos c22f2a1
Fix code examples (does fix errors)
Eckaos 292e84f
Fix subsumption
Eckaos 3bb123b
Fix subsumption
Eckaos b9db772
Improve the manual section on subtyping
yannham d824ff0
Add generic example to work around function subsumption
Eckaos d94da2b
Update doc/manual/typing.md
yannham e1f837e
Update doc/manual/typing.md
yannham 107d6a5
Fix format problem
Eckaos 77773a9
Update doc/manual/typing.md
yannham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...integration/inputs/typecheck/chaining_dictionary_function_record_dictionary_subtyping.ncl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# test.type = 'error' | ||
# [test.metadata] | ||
# error = 'EvalError::BlameError' | ||
let x = {foo = 1, bar = 2} in | ||
let y = std.record.insert "baz" 5 x in | ||
let _ = std.record.get "foo" y in | ||
let z = std.record.remove "foo" y in | ||
std.record.get "foo" z |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.