Refactor gatherStmt #1121
Merged
Refactor gatherStmt #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonchinn178
force-pushed
the
bchinn-gather-stmts
branch
from
0396deb
to
a9e3f56
Compare
amesgen
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Thanks, see #1119 (comment) for the motivation for this; I think it is now more intuitive/understandable (especially with the nice comment) than with the previous clever but somewhat confusing use of liftAppend 👍
Can you squash the commits?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chunk of code was a bit hard to digest, so rewritten to be easier to understand. Broken out from #1119