Move back to nixpkgs checkout #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
approved these changes
Jul 23, 2018
mrkkrp
reviewed
Jul 23, 2018
tests/ghc.nix
Outdated
|
|
||
| with pkgs; | ||
|
|
||
| let haskellPackages = pkgs.haskell.packages.ghc822.override { | ||
| overrides = with pkgs.haskell.lib; self: super: rec { | ||
| lens-labels = super.lens-labels_0_2_0_1; |
There was a problem hiding this comment.
Why not to delete the whole override if we don't actually change anything with it?
There was a problem hiding this comment.
Good point. Wasn't thinking!
tests/protoc_gen_haskell.nix
Outdated
| @@ -4,8 +4,8 @@ with pkgs; | |||
|
|
|||
| let haskellPackages = pkgs.haskell.packages.ghc822.override { | |||
| overrides = with pkgs.haskell.lib; self: super: rec { | |||
| lens-labels = super.lens-labels_0_2_0_1; | |||
| proto-lens = super.proto-lens_0_3_1_0; | |||
| lens-labels = super.lens-labels; | |||
We no longer need to pull bazel from cachix, now that NixOS/nixpkgs#42735 has been merged and has hit the cache.nixos.org cache.
mboes
force-pushed
the
bazel-from-nixpkgs
branch
from
deea510
to
411ea65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to pull bazel from cachix, now that
NixOS/nixpkgs#42735 has been merged and has
hit the cache.nixos.org cache.