Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hazel: Run ./configure in a build rule #858

Merged
merged 4 commits into from
May 9, 2019
Merged

Hazel: Run ./configure in a build rule #858

merged 4 commits into from
May 9, 2019

Commits on May 3, 2019

  1. Hazel: Don't run ./configure in repository rule 

    This violates hermeticity, as the ./configure script might pick up a
system compiler, and system libraries, which are later replaced through
library dependencies or cc toolchains.
    @aherrmann
    aherrmann committed May 3, 2019
    Configuration menu
    Copy the full SHA
    5730137 View commit details
    Browse the repository at this point in the history

  2. Hazel: Run ./configure in build rule

    @aherrmann
    aherrmann committed May 3, 2019
    Configuration menu
    Copy the full SHA
    cea4e47 View commit details
    Browse the repository at this point in the history

  3. Patch network.cabal 

    Running the ./configure script during build improves upon the
hermeticity issues. However, it prevents the use of Cabal buildinfo
files. The network configure script generates such a file that is then
meant to be used to patch the Cabal package definition.

However, we can work around this by instead defining conditional flags
in the network cabal file.
    @aherrmann
    aherrmann committed May 3, 2019
    Configuration menu
    Copy the full SHA
    aede580 View commit details
    Browse the repository at this point in the history

  4. Add network to Windows CI

    @aherrmann
    aherrmann committed May 3, 2019
    Configuration menu
    Copy the full SHA
    caf2a23 View commit details
    Browse the repository at this point in the history