-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples don't work on macOS CI runner #176
Comments
Thanks for writing up the context!
This is not strictly true. Nixpkgs is continuously built on hydra and pushed to the nixpkgs community cache in between releases as well. To find a cached nixpkgs revision that provides that bazel version you can
E.g. https://hydra.nixos.org/build/153268139 seems to fit the bill: It provides Bazel 4.2.1 and not contain the offending line in stdenv. A quick local test shows bazel being fetched from cache
See also here for some hints on how to find cached revisions. |
Indeed that wording is a bit too strict. I think pinning to releases is more representative of real-world usage however; if someone uses the example in the wild and wishes to update nixpkgs to get an updated toolchain, it might be a nasty surprise when it fails on macOS. |
On CI we set NIX_PATH to "nixpkgs=./nixpkgs.nix", so nix-shell tries to use it from within the example's directory and fails, it tries to use builtin bash. On macOS it is too old, so we should make sure that the one from nixpkgs is used. Related to #176
All examples are already using 21.11 nixpkgs, so they should work on Big Sur. Related to #176
Python example will be fixed in #186. |
Rust example will be fixed in #187. |
On CI we set NIX_PATH to "nixpkgs=./nixpkgs.nix", so nix-shell tries to use it from within the example's directory and fails, it tries to use builtin bash. On macOS it is too old, so we should make sure that the one from nixpkgs is used. Related to tweag#176
Describe the bug
The examples CI job does not work on any version of the macOS runner.
To Reproduce
Add
macos-11
ormacos-10.15
to the list of runners for the examples job.Expected behavior
CI jobs should pass.
Additional context
The text was updated successfully, but these errors were encountered: