Use nix-support/cc-{c,ld}flags files to configure compiler flags
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
nix-support-and-code-signing
branch
3 times, most recently
from
8a5c789
to
665950c
Compare
avdv
force-pushed
the
nix-support-and-code-signing
branch
from
665950c
to
5aa0b34
Compare
avdv
commented
May 18, 2022
The `bintools` attribute of a compiler derivation contains the corresponding binutils or cctools. Add some documentation and example code to explain how to use `nixpkgs_cc_configure`.
avdv
force-pushed
the
nix-support-and-code-signing
branch
from
b729eea
to
4a02190
Compare
aherrmann
reviewed
May 19, 2022
aherrmann
reviewed
May 19, 2022
This is necessary because the original `postLinkSignHook` assumes the `codesign_allocate` is in `PATH`.
aherrmann
approved these changes
May 19, 2022
Yes, it does. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This improves support for using rules_nixpkgs on Darwin where it is required to sign binaries.
Fixes #225 and fixes #224.