Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid error when include dirs list is empty #234

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Avoid error when include dirs list is empty #234

merged 2 commits into from
Jun 10, 2022

Conversation

avdv
Copy link
Member

@avdv avdv commented Jun 1, 2022

Originally raised by @dmadisetti in #220.

This PR just skips running the xargs command if there are no arguments read from stdin.

@dmadisetti
Copy link
Contributor

LGTM!

@avdv avdv requested a review from YorikSar June 2, 2022 06:32
@avdv avdv requested a review from aherrmann June 10, 2022 08:44
@avdv avdv added the merge-queue merge on green CI label Jun 10, 2022
aherrmann
aherrmann approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 1c02fe9 into master Jun 10, 2022
@mergify mergify bot deleted the avoid-error-for-empty-include-dirs branch June 10, 2022 09:17
@mergify mergify bot removed the merge-queue merge on green CI label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann aherrmann approved these changes

@YorikSar YorikSar Awaiting requested review from YorikSar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avdv @dmadisetti @aherrmann