-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to flake #265
Convert to flake #265
Conversation
At the moment there are two separate |
Yes, good point! I'll see if that works... |
* remove `core/flake.nix`
c94c02b
to
0c49af7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! (I'm still very new to Tweag and to Bazel, so somebody else should probably look it over as well)
Things I like about your approach:
- using nix-compat to not breaking the traditional workflow
- ability to use a single invocation of
nix flake
tool to manage pinning nixpkgs - actual use of this ruleset within Bazel does not depend on any experimental flake features
Thank you for the review! Another pair of eyes would have been good, but I accidentally already pushed this onto master... If somebody has any objections to this, let's just fix it in another PR.
👍 we might switch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only echo @tshaynik's comments, looks good, thank you!
nix-shell
usersflake.lock
instead ofnixpkgs.json