Fix Python container example #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change examples/python-container to pin the nixpkgs revision in the same way as the toolchain examples. Update the nixpkgs revision to 22.05 which is needed to include bazel_5.
Use the same `local_repository` setup as the other examples.
py_image transitively depends on a cc toolchain.
rules_docker's py_image requires a dedicated Python (and transitively C++) toolchain that is compatible with the `run_in_container` execution constraint. This collides with the nixpkgs host platform. So, we define a dedicated platform that fulfills both requirements.
MacOS requires appropriate cross-platform toolchain configration since the Docker image is a Linux target.
aherrmann
force-pushed
the
python-container-example
branch
from
d94d091
to
eddffa7
Compare
|
It turns out that a rules_docker Python image also requires a CC toolchain that fulfills the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example was still using an older nixpkgs revision that did not provide the required Bazel version 5. This PR updates the nixpkgs revision. This PR also adds the example to at least build the image on CI, to make sure that we notice any such discrepancies in the future.