Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenSSL in nix rust toolchain example #305

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Conversation

benradf
Copy link
Member

@benradf benradf commented Jan 10, 2023

Credit to @AleksanderGondek for doing the majority of this work in PR 235. I merely rebased onto latest master and got it working with CI. In the process I also encountered issue 281 and fixed it with the suggestion @cloneable made here.

Closes #207 and #281.

AleksanderGondek and others added 5 commits January 9, 2023 12:50
This commit introduces the basic usage of openssl rust crate in
nix rust toolchain example - which in turn, gives a good overview
of steps required to make rules_rust + nix work with any
packages which usually are delivered from the linux FHS.
@benradf benradf changed the title Investigating CI failures for PR 235 Use OpenSSL in nix rust toolchain example Jan 11, 2023
@benradf benradf marked this pull request as ready for review January 11, 2023 12:50
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@benradf benradf added the merge-queue merge on green CI label Jan 26, 2023
@mergify mergify bot merged commit 92b1c2d into master Jan 26, 2023
@mergify mergify bot deleted the ben/rust-openssl-example branch January 26, 2023 08:52
@mergify mergify bot removed the merge-queue merge on green CI label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example on bringing in Rust system dependencies (specifically OpenSSL)
3 participants