-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OpenSSL in nix rust toolchain example #305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the basic usage of openssl rust crate in nix rust toolchain example - which in turn, gives a good overview of steps required to make rules_rust + nix work with any packages which usually are delivered from the linux FHS.
benradf
force-pushed
the
ben/rust-openssl-example
branch
from
January 10, 2023 16:47
ff95241
to
b2e2165
Compare
benradf
force-pushed
the
ben/rust-openssl-example
branch
from
January 11, 2023 11:04
b850fc7
to
8d57b4c
Compare
benradf
changed the title
Investigating CI failures for PR 235
Use OpenSSL in nix rust toolchain example
Jan 11, 2023
avdv
reviewed
Jan 24, 2023
avdv
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Co-authored-by: Claudio Bley <[email protected]>
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @AleksanderGondek for doing the majority of this work in PR 235. I merely rebased onto latest master and got it working with CI. In the process I also encountered issue 281 and fixed it with the suggestion @cloneable made here.
Closes #207 and #281.