-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for nodejs toolchain with npm_install repository rule #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kczulko Thank you for raising and investigating this!
Probably we have to mimic the behavior that rules_haskell does (thx @ylecornec )
The link points to this PR again. Did you mean this?
@aherrmann @avdv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! That looks good!
Otherwise there were some "circular" (?) dependency issues which lead to a failures.
Bazel reports missing external repositories like that sometimes.
I think I am also missing some docs about this new way of configuring rules_nodejs under nix.
A good place to add them would be the docstring of the new nixpkgs_nodejs_configure_platforms
and also a docstring in nixpkgs_nodejs_configure
pointing to it. (Also a note in the CHANGELOG). You can look at other macros for the format of docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank @kczulko for pushing this through, great work!
Only one small comment. Feel free to apply and then add the merge-queue
label.
Co-authored-by: Andreas Herrmann <[email protected]>
While applying latest
rules_nodejs
(5.8.0
) to one of the projects I'm working on, I saw there's no longer an option to passvendored_node
tonpm_install
rule.Following this "migration guide" it was found out (thx @avdv @aherrmann ) that using proper
npm_install::node_reporitory
value does the job.However there's an issue of suffixing toolchain names which rules_nodejs does - see
nixpkgs-nodejs_linux_amd64
as one of the names. E.g. now macos build fails with:Probably we have to mimic the behavior that rules_haskell does (thx @ylecornec )