Update the Rust toolchain example #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
reviewed
Feb 2, 2023
Comment on lines
4
to
6
| "branch": "22.05", | ||
| "rev": "ce6aa13369b667ac2542593170993504932eb836", | ||
| "sha256": "0d643wp3l77hv2pmg2fi7vyxn4rwy0iyr8djcw1h5x72315ck9ik" | ||
| "rev": "73247c5ab2bc2037d7dd0d310f1fb43ed191edad", | ||
| "sha256": "1213j2gvsmzmhpyi2jyn729s9d0gbn56k3d873iknd5ilb2rvpcr" |
There was a problem hiding this comment.
What channel is that from? It doesn't look like it's 22.05 anymore. Would 22.11 suffice (as being updated here), or does it have to be more recent? If so, could you update the branch field accordingly?
Comment on lines
46
to
47
| + rust_toolchain_cargo_template (str, optional): The template to use for finding the host `cargo` binary. | ||
| + rust_toolchain_rustc_template (str, optional): The template to use for finding the host `rustc` binary. |
There was a problem hiding this comment.
why remove those from the patch?
There was a problem hiding this comment.
This was not intentional. The idea was to get it working, this patch being for internal use, not to be included upstream. I'm going to restore this and add the lines in another place where the API is also extended (cargo_bazel_bootstrap, which did not have such lines in the old patch).
mrkkrp
force-pushed
the
rust-toolchain-update
branch
from
62b7086
to
7fa4451
Compare
Update `rules_rust` to 0.17.0.
mrkkrp
force-pushed
the
rust-toolchain-update
branch
from
7fa4451
to
8ef8a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
rules_rustto 0.17.0.