-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of python modules with poetry #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pushing this forward! This is a really cool feature, and I don't think much is missing to have this ready to merge. I've added a couple comments.
f72dfed
to
323341a
Compare
Stuck on some disk space limitation. Probably /run/usr/${id} AFAIR, because nix uses that as $TMP and mach-nix fills it by unpacking it's database of all the python packages it knows. |
ab0632f
to
f2af843
Compare
This provides a solution to #346 for Python. |
Done, I think it is as ready as can be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @layus , this is great!
I've added a few more comments, but all of them are small comments.
Please address the comments and then feel free to add the merge-queue label.
Concerning mach-nix, it is way too difficult to make it work on recent nixpkgs, the project is currently unmaintained, and last update it received references a nixpkgs from one year ago. I remembered just in time that you can craft python packages sets manually in nixpkgs. |
@aherrmann Thanks for your thorough and fast reviews, working on this PR has been a real pleasure ! |
That sounds very exciting! Yes, perhaps there is even a way to use dream2nix more broadly for rules_nixpkgs integration of different languages.
Likewise, thank you for the great work! |
This has been long in the making, and currently it only works in a very
restricted setup. Nonetheless, it comes with a working example, so comments are
welcome.