Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix darwin flag when cross-compiling from Linux to MacOS #413

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Fix darwin flag when cross-compiling from Linux to MacOS #413

merged 4 commits into from
Sep 7, 2023

Conversation

benradf
Copy link
Member

@benradf benradf commented Sep 6, 2023 •
edited
Loading

In response to this comment from @jcpetruzza.

@benradf benradf mentioned this pull request Sep 6, 2023
Merged
@jcpetruzza
Copy link

Looks good to me!

aherrmann
aherrmann approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

examples/toolchains/cc_cross_osx_to_linux_amd64/README.md Outdated Show resolved Hide resolved
@benradf benradf added the merge-queue merge on green CI label Sep 7, 2023
@mergify mergify bot merged commit 4306671 into master Sep 7, 2023
15 checks passed
@mergify mergify bot deleted the fix_cross_cpu branch September 7, 2023 09:26
@mergify mergify bot removed the merge-queue merge on green CI label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DolceTriade DolceTriade DolceTriade approved these changes

@aherrmann aherrmann aherrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benradf @jcpetruzza @aherrmann @DolceTriade