Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.11.0 #488

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Release 0.11.0 #488

merged 1 commit into from
Mar 27, 2024

Conversation

prednaz
Copy link
Member

@prednaz prednaz commented Mar 27, 2024 •
edited
Loading

Creates release 0.11.0.

The next steps are:

  • Review & Merge this PR.
  • Publish the draft release.
  • Push a release v0.11.0 tag to the merge commit of this PR.
  • Get rules_nixpkgs_core 0.11.0 merged into the BCR.

@prednaz prednaz requested a review from benradf as a code owner March 27, 2024 01:03
@prednaz
Copy link
Member Author

prednaz commented Mar 27, 2024 •
edited
Loading

i wrote the CHANGELOG.md based on the output of git log --oneline --merges --grep='pull request' --grep='#' master ^v0.10.0 | grep -v 'tweag/dependabot/github_actions/' | grep -v 'tweag/update_flake_lock_action'.

i tried to filter out changes that are not user facing. i was unsure about #472 and #453. they are not user facing as far as i can tell.

benradf
benradf approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@benradf benradf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for doing this new release!

avdv
avdv requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@avdv avdv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM.

But I tested tweag/rules_haskell#2136 against these changes and I need to get one more fix in...

avdv
avdv approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is good now, PR #489 merged.

@prednaz prednaz added the merge-queue merge on green CI label Mar 27, 2024
@mergify mergify bot merged commit 65a48d2 into master Mar 27, 2024
15 checks passed
@mergify mergify bot deleted the release-0.11.0 branch March 27, 2024 21:40
@mergify mergify bot removed the merge-queue merge on green CI label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benradf benradf benradf approved these changes

@avdv avdv avdv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prednaz @avdv @benradf