Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make rules_nixpkgs_java depend on remote_java_tools properly #497

Merged
merged 2 commits into from
Apr 11, 2024
Merged

make rules_nixpkgs_java depend on remote_java_tools properly #497

merged 2 commits into from
Apr 11, 2024

Conversation

prednaz
Copy link
Member

@prednaz prednaz commented Apr 8, 2024 •
edited
Loading

this fixes the issue that users of rules_nixpkgs_java need to depend on a dependency of rules_nixpkgs_java, that is on remote_java_tools. examples are 8e44cce.

@prednaz
Copy link
Member Author

prednaz commented Apr 8, 2024 •
edited
Loading

i even suspect that repository name literals in .bzl files should probably always be wrapped in Label.

@prednaz
Copy link
Member Author

prednaz commented Apr 8, 2024

@layus pointed out that this fix has also long been available from upstream, that is from rules_java. is there more? can we deduplicate something here?

@prednaz prednaz requested a review from layus April 8, 2024 12:17
@prednaz prednaz marked this pull request as ready for review April 8, 2024 12:17
@prednaz prednaz requested a review from benradf as a code owner April 8, 2024 12:17
@prednaz prednaz changed the title depend on remote_java_tools properly make rules_nixpkgs_java depend on remote_java_tools properly Apr 8, 2024
@prednaz prednaz mentioned this pull request Apr 10, 2024
Merged
@prednaz prednaz added the merge-queue merge on green CI label Apr 11, 2024
@mergify mergify bot merged commit b6cf173 into master Apr 11, 2024
15 checks passed
@mergify mergify bot deleted the philipp/remote_java_tools branch April 11, 2024 20:47
@mergify mergify bot removed the merge-queue merge on green CI label Apr 11, 2024
@prednaz prednaz mentioned this pull request Apr 16, 2024
Closed
@prednaz prednaz self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benradf benradf benradf approved these changes

@layus layus Awaiting requested review from layus

Assignees

@prednaz prednaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prednaz @benradf